third_party/WebKit/Source/core/svg/SVGLengthList.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthList.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthList.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthList.cpp b/third_party/WebKit/Source/core/svg/SVGLengthList.cpp

index 238b63c1ac1e4dd2e8e5bc7083c04fdf5b8afd9a..d0f9759e237308f7cc10b2f579c29a10ca871c42 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthList.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthList.cpp

@@ -132,8 +132,8 @@ void SVGLengthList::calculateAnimatedValue(

toSVGLengthList(toAtEndOfDurationValue);

SVGLengthContext lengthContext(contextElement);

- ASSERT(m_mode == SVGLength::lengthModeForAnimatedLengthAttribute(

- animationElement->attributeName()));

+ DCHECK_EQ(m_mode, SVGLength::lengthModeForAnimatedLengthAttribute(

+ animationElement->attributeName()));

size_t fromLengthListSize = fromList->length();

size_t toLengthListSize = toList->length();