third_party/WebKit/Source/core/svg/SVGLengthContext.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp b/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

index de0637a6cd441858d986b78b513aac63967c9431..e778a50f779710857e5984b4b5c178b8162dd8ce 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

@@ -245,7 +245,7 @@ float SVGLengthContext::valueForLength(const Length& length,

float SVGLengthContext::valueForLength(const Length& length,

float zoom,

float dimension) {

- ASSERT(zoom != 0);

+ DCHECK_NE(zoom, 0);

// isIntrinsic can occur for 'width' and 'height', but has no

// real meaning for svg.

if (length.isIntrinsic())