third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

index 1072cfac439f5b23d289bd378cd37e8c59592772..d2aa191ff746d4e722434275ff28628fc32997f2 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

@@ -60,7 +60,7 @@ inline bool canResolveRelativeUnits(const SVGElement* contextElement) {

}

inline CSSPrimitiveValue::UnitType toCSSUnitType(unsigned short type) {

- ASSERT(isValidLengthUnit(type));

+ DCHECK(isValidLengthUnit(type));

if (type == SVGLengthTearOff::kSvgLengthtypeNumber)

return CSSPrimitiveValue::UnitType::UserUnits;

return static_cast<CSSPrimitiveValue::UnitType>(type);