Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2738823002:
Gn: Add support to generate Visual Studio 2017 solutions. (Closed)
DescriptionGn: Add support to generate Visual Studio 2017 solutions.
- Add a new command line vs2017 to generate 2017 solutions
- Keep 2015 as the default.
- Update the toolset version.
BUG=683729
Review-Url: https://codereview.chromium.org/2738823002
Cr-Commit-Position: refs/heads/master@{#456443}
Committed: https://chromium.googlesource.com/chromium/src/+/c20ee868a144b9f01eaeae39bba8e9921dee2635
Patch Set 1 #
Total comments: 3
Patch Set 2 : Fix of default version #
Messages
Total messages: 25 (13 generated)
alexis.menard@intel.com changed reviewers: + brettw@chromium.org, brucedawson@chromium.org
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
scottmg@chromium.org changed reviewers: + scottmg@chromium.org
https://codereview.chromium.org/2738823002/diff/1/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/2738823002/diff/1/tools/gn/command_gen.cc#new... tools/gn/command_gen.cc:198: VisualStudioWriter::Version version = VisualStudioWriter::Version::Vs2013; This changes the default (when not explicitly set) to 2013, but I think it used to be 2015. I think it should remain 2015 for now. https://codereview.chromium.org/2738823002/diff/1/tools/gn/visual_studio_writ... File tools/gn/visual_studio_writer.cc (right): https://codereview.chromium.org/2738823002/diff/1/tools/gn/visual_studio_writ... tools/gn/visual_studio_writer.cc:74: const char kToolsetVersionVs2017[] = "v141"; // Visual Studio 2017 Sigh at 141 :/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/07 21:37:10, scottmg wrote: > https://codereview.chromium.org/2738823002/diff/1/tools/gn/command_gen.cc > File tools/gn/command_gen.cc (right): > > https://codereview.chromium.org/2738823002/diff/1/tools/gn/command_gen.cc#new... > tools/gn/command_gen.cc:198: VisualStudioWriter::Version version = > VisualStudioWriter::Version::Vs2013; > This changes the default (when not explicitly set) to 2013, but I think it used > to be 2015. I think it should remain 2015 for now. Yes fixed. Oversight on my side. > > https://codereview.chromium.org/2738823002/diff/1/tools/gn/visual_studio_writ... > File tools/gn/visual_studio_writer.cc (right): > > https://codereview.chromium.org/2738823002/diff/1/tools/gn/visual_studio_writ... > tools/gn/visual_studio_writer.cc:74: const char kToolsetVersionVs2017[] = > "v141"; // Visual Studio 2017 > Sigh at 141 :/ Why?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2738823002/diff/1/tools/gn/visual_studio_writ... File tools/gn/visual_studio_writer.cc (right): https://codereview.chromium.org/2738823002/diff/1/tools/gn/visual_studio_writ... tools/gn/visual_studio_writer.cc:74: const char kToolsetVersionVs2017[] = "v141"; // Visual Studio 2017 On 2017/03/07 21:37:09, scottmg wrote: > Sigh at 141 :/ There was a certain symmetry they had going with 120==VS12, 140==VS14, but then 141 != VS15. Oh well.
lgtm
On 2017/03/07 22:08:26, brucedawson wrote: > lgtm @brettw mind reviewing?
lgtm
The CQ bit was checked by alexis.menard@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489429392144000,
"parent_rev": "55d04434949276c4a20bde3167540d4cffa660c7", "commit_rev":
"c20ee868a144b9f01eaeae39bba8e9921dee2635"}
Message was sent while issue was closed.
Description was changed from ========== Gn: Add support to generate Visual Studio 2017 solutions. - Add a new command line vs2017 to generate 2017 solutions - Keep 2015 as the default. - Update the toolset version. BUG=683729 ========== to ========== Gn: Add support to generate Visual Studio 2017 solutions. - Add a new command line vs2017 to generate 2017 solutions - Keep 2015 as the default. - Update the toolset version. BUG=683729 Review-Url: https://codereview.chromium.org/2738823002 Cr-Commit-Position: refs/heads/master@{#456443} Committed: https://chromium.googlesource.com/chromium/src/+/c20ee868a144b9f01eaeae39bba8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c20ee868a144b9f01eaeae39bba8...
Message was sent while issue was closed.
On 2017/03/13 18:42:02, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/chromium/src/+/c20ee868a144b9f01eaeae39bba8... How do you roll a new gn binary?
Message was sent while issue was closed.
On 2017/03/13 18:44:22, darktears wrote: > On 2017/03/13 18:42:02, commit-bot: I haz the power wrote: > > Committed patchset #2 (id:20001) as > > > https://chromium.googlesource.com/chromium/src/+/c20ee868a144b9f01eaeae39bba8... > > How do you roll a new gn binary? Someone at Google can do it for you. I'll post a CL later today. -- Dirk
Message was sent while issue was closed.
On 2017/03/13 18:57:26, Dirk Pranke (slow until 28th) wrote: > On 2017/03/13 18:44:22, darktears wrote: > > On 2017/03/13 18:42:02, commit-bot: I haz the power wrote: > > > Committed patchset #2 (id:20001) as > > > > > > https://chromium.googlesource.com/chromium/src/+/c20ee868a144b9f01eaeae39bba8... > > > > How do you roll a new gn binary? > > Someone at Google can do it for you. I'll post a CL later today. > > -- Dirk Has this been done? I'm using VS 2017 so it would be nice. Thanks. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
