Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: tools/gn/command_gen.cc

Issue 2738823002: Gn: Add support to generate Visual Studio 2017 solutions. (Closed)
Patch Set: Fix of default version Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index 26fc729f7cfd97f8e482469f1e0572414585a215..194cace3f8609e00e9e2efe939ea42067c2f5d09 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -36,6 +36,7 @@ const char kSwitchIdeValueQtCreator[] = "qtcreator";
const char kSwitchIdeValueVs[] = "vs";
const char kSwitchIdeValueVs2013[] = "vs2013";
const char kSwitchIdeValueVs2015[] = "vs2015";
+const char kSwitchIdeValueVs2017[] = "vs2017";
const char kSwitchIdeValueXcode[] = "xcode";
const char kSwitchIdeValueJson[] = "json";
const char kSwitchNinjaExtraArgs[] = "ninja-extra-args";
@@ -193,10 +194,13 @@ bool RunIdeWriter(const std::string& ide,
}
return res;
} else if (ide == kSwitchIdeValueVs || ide == kSwitchIdeValueVs2013 ||
- ide == kSwitchIdeValueVs2015) {
- VisualStudioWriter::Version version =
- ide == kSwitchIdeValueVs2013 ? VisualStudioWriter::Version::Vs2013
- : VisualStudioWriter::Version::Vs2015;
+ ide == kSwitchIdeValueVs2015 || ide == kSwitchIdeValueVs2017) {
+ VisualStudioWriter::Version version = VisualStudioWriter::Version::Vs2015;
+ if (ide == kSwitchIdeValueVs2013)
+ version = VisualStudioWriter::Version::Vs2013;
+ else if (ide == kSwitchIdeValueVs2017)
+ version = VisualStudioWriter::Version::Vs2017;
+
std::string sln_name;
if (command_line->HasSwitch(kSwitchSln))
sln_name = command_line->GetSwitchValueASCII(kSwitchSln);
@@ -293,6 +297,7 @@ IDE options
(default Visual Studio version: 2015)
"vs2013" - Visual Studio 2013 project/solution files.
"vs2015" - Visual Studio 2015 project/solution files.
+ "vs2017" - Visual Studio 2017 project/solution files.
"xcode" - Xcode workspace/solution files.
"qtcreator" - QtCreator project files.
"json" - JSON file containing target information
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698