Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 2738793002: Revert of Disable pausing background video-only players on desktop. (Closed)

Created:
3 years, 9 months ago by whywhat
Modified:
3 years, 9 months ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, erickung+watch_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable pausing background video-only players on desktop. (patchset #2 id:20001 of https://codereview.chromium.org/2734963003/ ) Reason for revert: Was intended only to merge to 58. Original issue's description: > Disable pausing background video-only players on desktop. > > The intent is to merge this to M58 to launch the background video > optimizations that do both pausing for video-only and disabling the > video track for audible videos. > > BUG=699106 > TEST=existing tests > > Review-Url: https://codereview.chromium.org/2734963003 > Cr-Commit-Position: refs/heads/master@{#455187} > Committed: https://chromium.googlesource.com/chromium/src/+/60588ea13e075f43e47cd97d6911b8c50ce5d579 TBR=dalecurtis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699106 Review-Url: https://codereview.chromium.org/2738793002 Cr-Commit-Position: refs/heads/master@{#455203} Committed: https://chromium.googlesource.com/chromium/src/+/0a44cbf733c9d8f7589bd2856c0247486f3a7cce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M content/browser/media/session/media_session_impl_visibility_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
whywhat
Created Revert of Disable pausing background video-only players on desktop.
3 years, 9 months ago (2017-03-07 20:30:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738793002/1
3 years, 9 months ago (2017-03-07 20:31:22 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:41:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a44cbf733c9d8f7589bd2856c02...

Powered by Google App Engine
This is Rietveld 408576698