Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2738783003: Rename ChildrenWidgetSet to ChildrenSet (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kenneth.christiansen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ChildrenWidgetSet to ChildrenSet BUG=697351 Review-Url: https://codereview.chromium.org/2738783003 Cr-Commit-Position: refs/heads/master@{#455399} Committed: https://chromium.googlesource.com/chromium/src/+/97b851195835fc2e6dfc60e1e05e770425e4df6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
joelhockey
3 years, 9 months ago (2017-03-08 02:52:54 UTC) #2
slangley
lgtm
3 years, 9 months ago (2017-03-08 03:35:22 UTC) #5
joelhockey
3 years, 9 months ago (2017-03-08 03:35:42 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-08 06:08:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738783003/1
3 years, 9 months ago (2017-03-08 06:09:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/402624)
3 years, 9 months ago (2017-03-08 06:50:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738783003/1
3 years, 9 months ago (2017-03-08 06:57:25 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 08:23:10 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97b851195835fc2e6dfc60e1e05e...

Powered by Google App Engine
This is Rietveld 408576698