Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2738783003: Rename ChildrenWidgetSet to ChildrenSet (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 updateScrollbarGeometry(); 483 updateScrollbarGeometry();
484 updateScrollCorner(); 484 updateScrollCorner();
485 positionScrollbarLayers(); 485 positionScrollbarLayers();
486 } 486 }
487 } 487 }
488 488
489 void FrameView::invalidateAllCustomScrollbarsOnActiveChanged() { 489 void FrameView::invalidateAllCustomScrollbarsOnActiveChanged() {
490 bool usesWindowInactiveSelector = 490 bool usesWindowInactiveSelector =
491 m_frame->document()->styleEngine().usesWindowInactiveSelector(); 491 m_frame->document()->styleEngine().usesWindowInactiveSelector();
492 492
493 const ChildrenWidgetSet* viewChildren = children(); 493 const ChildrenSet* viewChildren = children();
494 for (const Member<FrameViewBase>& child : *viewChildren) { 494 for (const Member<FrameViewBase>& child : *viewChildren) {
495 FrameViewBase* frameViewBase = child.get(); 495 FrameViewBase* frameViewBase = child.get();
496 if (frameViewBase->isFrameView()) { 496 if (frameViewBase->isFrameView()) {
497 toFrameView(frameViewBase) 497 toFrameView(frameViewBase)
498 ->invalidateAllCustomScrollbarsOnActiveChanged(); 498 ->invalidateAllCustomScrollbarsOnActiveChanged();
499 } else if (usesWindowInactiveSelector && frameViewBase->isScrollbar() && 499 } else if (usesWindowInactiveSelector && frameViewBase->isScrollbar() &&
500 toScrollbar(frameViewBase)->isCustomScrollbar()) { 500 toScrollbar(frameViewBase)->isCustomScrollbar()) {
501 toScrollbar(frameViewBase)->styleChanged(); 501 toScrollbar(frameViewBase)->styleChanged();
502 } 502 }
503 } 503 }
(...skipping 2799 matching lines...) Expand 10 before | Expand all | Expand 10 after
3303 if (needsLayout()) 3303 if (needsLayout())
3304 layout(); 3304 layout();
3305 3305
3306 checkDoesNotNeedLayout(); 3306 checkDoesNotNeedLayout();
3307 3307
3308 // WebView plugins need to update regardless of whether the 3308 // WebView plugins need to update regardless of whether the
3309 // LayoutEmbeddedObject that owns them needed layout. 3309 // LayoutEmbeddedObject that owns them needed layout.
3310 // TODO(leviw): This currently runs the entire lifecycle on plugin WebViews. 3310 // TODO(leviw): This currently runs the entire lifecycle on plugin WebViews.
3311 // We should have a way to only run these other Documents to the same 3311 // We should have a way to only run these other Documents to the same
3312 // lifecycle stage as this frame. 3312 // lifecycle stage as this frame.
3313 const ChildrenWidgetSet* viewChildren = children(); 3313 const ChildrenSet* viewChildren = children();
3314 for (const Member<FrameViewBase>& child : *viewChildren) { 3314 for (const Member<FrameViewBase>& child : *viewChildren) {
3315 if ((*child).isPluginContainer()) 3315 if ((*child).isPluginContainer())
3316 toPluginView(child.get())->updateAllLifecyclePhases(); 3316 toPluginView(child.get())->updateAllLifecyclePhases();
3317 } 3317 }
3318 checkDoesNotNeedLayout(); 3318 checkDoesNotNeedLayout();
3319 3319
3320 // FIXME: Calling layout() shouldn't trigger script execution or have any 3320 // FIXME: Calling layout() shouldn't trigger script execution or have any
3321 // observable effects on the frame tree but we're not quite there yet. 3321 // observable effects on the frame tree but we're not quite there yet.
3322 HeapVector<Member<FrameView>> frameViews; 3322 HeapVector<Member<FrameView>> frameViews;
3323 for (Frame* child = m_frame->tree().firstChild(); child; 3323 for (Frame* child = m_frame->tree().firstChild(); child;
(...skipping 1929 matching lines...) Expand 10 before | Expand all | Expand 10 after
5253 void FrameView::setAnimationHost( 5253 void FrameView::setAnimationHost(
5254 std::unique_ptr<CompositorAnimationHost> host) { 5254 std::unique_ptr<CompositorAnimationHost> host) {
5255 m_animationHost = std::move(host); 5255 m_animationHost = std::move(host);
5256 } 5256 }
5257 5257
5258 LayoutUnit FrameView::caretWidth() const { 5258 LayoutUnit FrameView::caretWidth() const {
5259 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5259 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5260 } 5260 }
5261 5261
5262 } // namespace blink 5262 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698