Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2738773003: [Merge M58] Fix crash whem window created before shelf creation. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] Fix crash whem window created before shelf creation. This fix crash due race condition in multi-profile mode in case some window is created before shelf initialized. Easiest way to repo is on fresh machine first sign-in to public account, sign-out, sign-in to corp Google account. ARC++ OptIn window should pop-up on start. NOTRY=true NOPRESUBMIT=true TBR=skuhne@chromium.org BUG=684860 TEST=Manually, no more crashes. Review-Url: https://codereview.chromium.org/2736993002 Cr-Commit-Position: refs/heads/master@{#455315} (cherry picked from commit a89719254bb2ba3420b3eefb14b811f711532f99) Review-Url: https://codereview.chromium.org/2738773003 Cr-Commit-Position: refs/branch-heads/3029@{#55} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/eb7089ad459643fd6e0c2b1def42fbb8e1c50284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738773003/1
3 years, 9 months ago (2017-03-08 01:18:16 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:22:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb7089ad459643fd6e0c2b1def42...

Powered by Google App Engine
This is Rietveld 408576698