Fix crash whem window created before shelf creation.

Fix crash whem window created before shelf creation.

This fix crash due race condition in multi-profile mode in case some
window is created before shelf initialized. Easiest way to repo is
on fresh machine first sign-in to public account, sign-out, sign-in
to corp Google account. ARC++ OptIn window should pop-up on start.

BUG=684860
TEST=Manually, no more crashes.

Review-Url: https://codereview.chromium.org/2736993002
Cr-Commit-Position: refs/heads/master@{#455315}
Committed: https://chromium.googlesource.com/chromium/src/+/a89719254bb2ba3420b3eefb14b811f711532f99

[khmel, 2017-03-07 18:17:07]

The CQ bit was checked by khmel@chromium.org to run a CQ dry run

[khmel, 2017-03-07 18:17:40]

khmel@chromium.org changed reviewers:
+ skuhne@chromium.org

[khmel, 2017-03-07 18:17:40]

Hi Stefan,

PTAL,

Thanks!

[commit-bot: I haz the power, 2017-03-07 18:18:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:50:37]

Dry run: This issue passed the CQ dry run.

[Mr4D (OOO till 08-26), 2017-03-08 00:46:02]

lgtm

https://codereview.chromium.org/2736993002/diff/1/chrome/browser/ui/ash/launc...
File
chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc
(right):

https://codereview.chromium.org/2736993002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc:72:
DCHECK(registry->app_windows().empty());
I think this is correct. (At least unless we have windows which are on all
desktops - which is thinkable).

[khmel, 2017-03-08 00:47:30]

Thank you!

[khmel, 2017-03-08 00:47:41]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:48:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:54:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488934061589930, "parent_rev":
"5403a879208075dee8985dfab15f436ae9b1fb97", "commit_rev":
"a89719254bb2ba3420b3eefb14b811f711532f99"}

[commit-bot: I haz the power, 2017-03-08 00:55:28]

Description was changed from

==========
Fix crash whem window created before shelf creation.

This fix crash due race condition in multi-profile mode in case some
window is created before shelf initialized. Easiest way to repo is
on fresh machine first sign-in to public account, sign-out, sign-in
to corp Google account. ARC++ OptIn window should pop-up on start.

BUG=684860
TEST=Manually, no more crashes.
==========

to

==========
Fix crash whem window created before shelf creation.

This fix crash due race condition in multi-profile mode in case some
window is created before shelf initialized. Easiest way to repo is
on fresh machine first sign-in to public account, sign-out, sign-in
to corp Google account. ARC++ OptIn window should pop-up on start.

BUG=684860
TEST=Manually, no more crashes.

Review-Url: https://codereview.chromium.org/2736993002
Cr-Commit-Position: refs/heads/master@{#455315}
Committed:
https://chromium.googlesource.com/chromium/src/+/a89719254bb2ba3420b3eefb14b8...
==========

[commit-bot: I haz the power, 2017-03-08 00:55:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a89719254bb2ba3420b3eefb14b8...