Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2738743003: Making the AIDL GN target support multiple include directories. (Closed)

Created:
3 years, 9 months ago by Jay Civelli
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, zpeng+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making the AIDL GN target support multiple include directories. This is needed by a follow up patch that adds Java Parcelable's support to Mojo. BUG=699288 TBR=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2738743003 Cr-Commit-Position: refs/heads/master@{#455504} Committed: https://chromium.googlesource.com/chromium/src/+/3e97d4db7e7a6bd09f0dea98fb347ce61bdcda05

Patch Set 1 : Making the AIDL GN tag support multiple include directories. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M android_webview/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 chunk +13 lines, -11 lines 0 comments Download
M chrome/android/webapk/libs/runtime_library/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (16 generated)
Jay Civelli
3 years, 9 months ago (2017-03-07 23:14:26 UTC) #7
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-08 02:02:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738743003/20001
3 years, 9 months ago (2017-03-08 17:32:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/381031)
3 years, 9 months ago (2017-03-08 17:40:42 UTC) #15
Jay Civelli
Adding OWNER reviewer, could you please take a look at: boliu@ android_webview/BUILD.gn and content/public/android/BUILD.gn phajdan.jr@ ...
3 years, 9 months ago (2017-03-08 17:46:39 UTC) #17
boliu
On 2017/03/08 17:46:39, Jay Civelli wrote: > Adding OWNER reviewer, could you please take a ...
3 years, 9 months ago (2017-03-08 17:55:31 UTC) #18
Xi Han
WebAPK lgtm
3 years, 9 months ago (2017-03-08 17:59:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738743003/20001
3 years, 9 months ago (2017-03-08 18:44:17 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 18:52:53 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e97d4db7e7a6bd09f0dea98fb34...

Powered by Google App Engine
This is Rietveld 408576698