Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2735113003: Changing SpawnChild to return a struct.

Created:
3 years, 9 months ago by Jay Civelli
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, viettrungluu+watch_chromium.org, jam, gavinp+memory_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, darin (slow to review), jbudorick+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changing SpawnChild to return a struct. This is needed by a follow-up CL that adds Parcelable channels to support sending Android parcelables over Mojo channels. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1511 lines, -174 lines) Patch
M base/BUILD.gn View 7 chunks +19 lines, -0 lines 0 comments Download
A base/android/global_object_registry.h View 1 chunk +47 lines, -0 lines 0 comments Download
A base/android/global_object_registry.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/IParcelableChannel.aidl View 1 chunk +14 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/ParcelableChannelClient.java View 1 chunk +36 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/ParcelableChannelServer.java View 1 chunk +64 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/ParcelableWrapper.aidl View 1 chunk +7 lines, -0 lines 0 comments Download
base/android/java/src/org/chromium/base/ParcelableWrapper.java View 1 chunk +59 lines, -0 lines 0 comments Download
base/android/jni_array.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/android/jni_array.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A base/android/parcelable_channel_client.h View 1 chunk +38 lines, -0 lines 0 comments Download
A base/android/parcelable_channel_client.cc View 1 chunk +41 lines, -0 lines 0 comments Download
base/android/parcelable_channel_server.h View 1 chunk +37 lines, -0 lines 0 comments Download
A base/android/parcelable_channel_server.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M base/debug/stack_trace_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/files/file_locking_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
base/memory/shared_memory_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/process/process_metrics_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/process/process_unittest.cc View 10 chunks +22 lines, -10 lines 0 comments Download
base/process/process_util_unittest.cc View 14 chunks +34 lines, -14 lines 0 comments Download
base/test/BUILD.gn View 4 chunks +5 lines, -0 lines 0 comments Download
M base/test/android/java/src/org/chromium/base/ITestClient.aidl View 2 chunks +4 lines, -1 line 0 comments Download
A base/test/android/java/src/org/chromium/base/LaunchClientResult.java View 1 chunk +40 lines, -0 lines 0 comments Download
base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java View 7 chunks +28 lines, -6 lines 0 comments Download
M base/test/android/java/src/org/chromium/base/MultiprocessTestClientService.java View 2 chunks +24 lines, -3 lines 0 comments Download
A base/test/android/jni_test_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A base/test/android/jni_test_util.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M base/test/multiprocess_test.h View 4 chunks +20 lines, -8 lines 0 comments Download
base/test/multiprocess_test.cc View 4 chunks +5 lines, -4 lines 0 comments Download
base/test/multiprocess_test_android.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/component_flash_hint_file_linux_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/multi_process_lock_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
mojo/edk/embedder/connection_param.h View 1 chunk +66 lines, -0 lines 0 comments Download
A mojo/edk/embedder/connection_param.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 3 chunks +31 lines, -1 line 0 comments Download
mojo/edk/embedder/embedder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
mojo/edk/embedder/parcelable_channel.h View 1 chunk +39 lines, -0 lines 0 comments Download
M mojo/edk/embedder/pending_process_connection.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/embedder/pending_process_connection.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_handle.h View 5 chunks +19 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_handle.cc View 2 chunks +8 lines, -0 lines 0 comments Download
mojo/edk/system/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/broker_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/channel.h View 6 chunks +35 lines, -2 lines 0 comments Download
M mojo/edk/system/channel.cc View 9 chunks +81 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_posix.cc View 10 chunks +81 lines, -7 lines 0 comments Download
M mojo/edk/system/core.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/core.cc View 7 chunks +29 lines, -6 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 6 chunks +20 lines, -6 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 4 chunks +76 lines, -7 lines 0 comments Download
mojo/edk/system/node_channel.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/node_channel.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/node_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 13 chunks +52 lines, -32 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M mojo/public/c/system/platform_handle.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/system/platform_handle.h View 3 chunks +19 lines, -0 lines 0 comments Download
mojo/public/cpp/system/platform_handle.cc View 2 chunks +42 lines, -0 lines 0 comments Download
M services/service_manager/runner/host/service_process_launcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
services/service_manager/tests/service_manager/service_manager_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
services/service_manager/tests/util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M testing/android/native_test/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
testing/android/native_test/java/AndroidManifest.xml.jinja2 View 1 chunk +7 lines, -0 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/MainRunner.java View 1 chunk +6 lines, -4 lines 0 comments Download
M testing/android/native_test/main_runner.cc View 4 chunks +18 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2738743003 Patch 20001

Powered by Google App Engine
This is Rietveld 408576698