Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2738713004: Fix crash when reporting error involving constructor. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add special case for ThisAccessor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests/co19/co19-kernel.status View 3 chunks +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 9 months ago (2017-03-08 15:37:46 UTC) #2
ahe
Uploaded a new patch set.
3 years, 9 months ago (2017-03-08 15:57:59 UTC) #3
karlklose
LGTM
3 years, 9 months ago (2017-03-09 09:51:28 UTC) #4
ahe
3 years, 9 months ago (2017-03-09 12:50:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7584921253985aa9fce47880cc5120ac52825a9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698