Compile-time errors instead of internal errors.

Compile-time errors instead of internal errors.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/95715d66ac31a9e9ff828e16bcbbb66895e64bcc

[ahe, 2017-03-08 16:36:54]

ahe@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-03-09 10:48:27]

LGTM

https://codereview.chromium.org/2735393002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart (right):

https://codereview.chromium.org/2735393002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart:60: abstract class
BuilderAccessor implements Accessor {
Please add a TODO to document this hierarchy.

[ahe, 2017-03-09 13:03:11]

Thank you, Karl!

https://codereview.chromium.org/2735393002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart (right):

https://codereview.chromium.org/2735393002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart:60: abstract class
BuilderAccessor implements Accessor {
On 2017/03/09 10:48:26, karlklose wrote:
> Please add a TODO to document this hierarchy.

I created this bug instead: https://github.com/dart-lang/sdk/issues/28999

[ahe, 2017-03-09 13:07:39]

Description was changed from

==========
Compile-time errors instead of internal errors.
==========

to

==========
Compile-time errors instead of internal errors.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95715d66ac31a9e9ff828e16bcbbb66895e64bcc
==========

[ahe, 2017-03-09 13:07:41]

Committed patchset #1 (id:1) manually as
95715d66ac31a9e9ff828e16bcbbb66895e64bcc (presubmit successful).