Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2736263002: Report compile-time error instead of crashing when encountering bad parts. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report compile-time error instead of crashing when encountering bad parts. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/471c0852ce7d6d5cccdbc4fc96b81d25a214a622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M pkg/front_end/lib/src/fasta/export.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 9 months ago (2017-03-08 15:30:00 UTC) #3
karlklose
LGTM
3 years, 9 months ago (2017-03-09 09:49:41 UTC) #4
ahe
3 years, 9 months ago (2017-03-09 12:42:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
471c0852ce7d6d5cccdbc4fc96b81d25a214a622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698