Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2738503002: Omnibox - Cleanup - Delete omnibox/features.h (Closed)

Created:
3 years, 9 months ago by Mark P
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, jdonnelly+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Cleanup - Delete omnibox/features.h We decided to put all feature flags in omnibox_field_trial.h, not components/omnibox/browser/features.h. BUG=697577 Review-Url: https://codereview.chromium.org/2738503002 Cr-Commit-Position: refs/heads/master@{#454999} Committed: https://chromium.googlesource.com/chromium/src/+/c4ae3d1876ab3f2b7e816216877e4ec3af5b243b

Patch Set 1 #

Patch Set 2 : tentative changelist; not yet compiled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D components/omnibox/browser/features.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/omnibox/browser/features.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M components/omnibox/browser/omnibox_field_trial.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/omnibox/browser/omnibox_field_trial.cc View 1 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Mark P
Please take a look at your leisure. thanks, mark
3 years, 9 months ago (2017-03-06 19:49:16 UTC) #3
Peter Kasting
LGTM
3 years, 9 months ago (2017-03-06 19:52:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738503002/20001
3 years, 9 months ago (2017-03-06 20:49:26 UTC) #9
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-06 21:11:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738503002/20001
3 years, 9 months ago (2017-03-06 23:33:31 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 23:40:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c4ae3d1876ab3f2b7e816216877e...

Powered by Google App Engine
This is Rietveld 408576698