Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 2738503002: Omnibox - Cleanup - Delete omnibox/features.h (Closed)
Patch Set: tentative changelist; not yet compiled Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index 0ca581ed7cf58adc8cb922a9c738700ccf131ecf..378027ff0bc2748b7e25fac1086ed2b30034d053 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -17,7 +17,6 @@
#include "base/time/time.h"
#include "build/build_config.h"
#include "components/metrics/proto/omnibox_event.pb.h"
-#include "components/omnibox/browser/features.h"
#include "components/omnibox/browser/omnibox_switches.h"
#include "components/omnibox/browser/url_index_private_data.h"
#include "components/search/search.h"
@@ -68,6 +67,15 @@ const base::Feature kSearchProviderContextAllowHttpsUrls{
"OmniboixSearchProviderContextAllowHttpsUrls",
base::FEATURE_DISABLED_BY_DEFAULT};
+// Feature used for the Zero Suggest Redirect to Chrome Field Trial.
+const base::Feature kZeroSuggestRedirectToChrome{
+ "ZeroSuggestRedirectToChrome", base::FEATURE_DISABLED_BY_DEFAULT};
+
+// Feature used to swap the title and URL when providing zero suggest
+// suggestions.
+const base::Feature kZeroSuggestSwapTitleAndUrl{
+ "ZeroSuggestSwapTitleAndUrl", base::FEATURE_DISABLED_BY_DEFAULT};
+
} // namespace omnibox
namespace {
@@ -557,7 +565,7 @@ OmniboxFieldTrial::GetEmphasizeTitlesConditionForInput(
const AutocompleteInput& input) {
// First, check if we should emphasize titles for zero suggest suggestions.
if (input.from_omnibox_focus() &&
- base::FeatureList::IsEnabled(features::kZeroSuggestSwapTitleAndUrl)) {
+ base::FeatureList::IsEnabled(omnibox::kZeroSuggestSwapTitleAndUrl)) {
return EMPHASIZE_WHEN_NONEMPTY;
}
// Look up the parameter named kEmphasizeTitlesRule + ":" + input.type(),
@@ -625,20 +633,20 @@ int OmniboxFieldTrial::GetPhysicalWebAfterTypingBaseRelevance() {
// static
bool OmniboxFieldTrial::InZeroSuggestRedirectToChromeFieldTrial() {
- return base::FeatureList::IsEnabled(features::kZeroSuggestRedirectToChrome);
+ return base::FeatureList::IsEnabled(omnibox::kZeroSuggestRedirectToChrome);
}
// static
std::string OmniboxFieldTrial::ZeroSuggestRedirectToChromeServerAddress() {
return base::GetFieldTrialParamValueByFeature(
- features::kZeroSuggestRedirectToChrome,
+ omnibox::kZeroSuggestRedirectToChrome,
kZeroSuggestRedirectToChromeServerAddressParam);
}
// static
std::string OmniboxFieldTrial::ZeroSuggestRedirectToChromeAdditionalFields() {
return base::GetFieldTrialParamValueByFeature(
- features::kZeroSuggestRedirectToChrome,
+ omnibox::kZeroSuggestRedirectToChrome,
kZeroSuggestRedirectToChromeAdditionalFieldsParam);
}
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698