Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2738073002: Revert of wire PasswordProtectionService into PasswordReuseDetectionManager (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 9 months ago
Reviewers:
dvadym
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of wire PasswordProtectionService into PasswordReuseDetectionManager (patchset #4 id:110001 of https://codereview.chromium.org/2734863004/ ) Reason for revert: This CL causes crashes crbug.com/699551 Original issue's description: > wire PasswordProtectionService into PasswordReuseDetectionManager > > Wire PasswordProtectionService into PasswordReuseDetectionManager to > help log non-whitelisted password-reuses to UMA > > BUG=691103 > > Review-Url: https://codereview.chromium.org/2734863004 > Cr-Commit-Position: refs/heads/master@{#455250} > Committed: https://chromium.googlesource.com/chromium/src/+/3b7571b5b5900a3d4582d62abe23b1a193bbee83 TBR=dvadym@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=691103 Review-Url: https://codereview.chromium.org/2738073002 Cr-Commit-Position: refs/heads/master@{#455628} Committed: https://chromium.googlesource.com/chromium/src/+/e1687f47332e8001e48d883c683d810e3c1311b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_reuse_detection_manager.h View 3 chunks +0 lines, -13 lines 0 comments Download
M components/password_manager/core/browser/password_reuse_detection_manager.cc View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jialiu Lin
Created Revert of wire PasswordProtectionService into PasswordReuseDetectionManager
3 years, 9 months ago (2017-03-09 00:00:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738073002/1
3 years, 9 months ago (2017-03-09 00:01:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:41:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e1687f47332e8001e48d883c683d...

Powered by Google App Engine
This is Rietveld 408576698