Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2738073002: Revert of wire PasswordProtectionService into PasswordReuseDetectionManager (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_reuse_detection_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_reuse_detection_manager.cc
diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc
index afd1a8e5035488021385296c40faf4eb227f68ad..24a7c4f8e5e992bb6d7920736d3dd5d0e1914439 100644
--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc
+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc
@@ -9,9 +9,6 @@
#include "components/password_manager/core/browser/password_manager_client.h"
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/browser/password_manager_util.h"
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
-#include "components/safe_browsing/password_protection/password_protection_service.h"
-#endif
namespace password_manager {
@@ -26,13 +23,6 @@
}
PasswordReuseDetectionManager::~PasswordReuseDetectionManager() {}
-
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
-void PasswordReuseDetectionManager::SetPasswordProtectionService(
- base::WeakPtr<safe_browsing::PasswordProtectionService> pp_service) {
- password_protection_service_ = pp_service;
-}
-#endif
void PasswordReuseDetectionManager::DidNavigateMainFrame(
const GURL& main_frame_url) {
@@ -70,10 +60,6 @@
metrics_util::LogPasswordReuse(
password.size(), saved_passwords, number_matches,
client_->GetPasswordManager()->IsPasswordFieldDetectedOnPage());
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
- if (password_protection_service_)
- password_protection_service_->RecordPasswordReuse(main_frame_url_);
-#endif
}
} // namespace password_manager
« no previous file with comments | « components/password_manager/core/browser/password_reuse_detection_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698