Removes unnecessary calls to FocusManager

Removes unnecessary calls to FocusManager

In general View::RequestFocus() and FocusManager::SetFocusedView() do
the same thing. The only exception to that is the SetFocusedView()
does not check if the view wants focus, where as View::RequestFocus()
does. For the cases I'm changing here RequestFocus() is fine.

BUG=none
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2738063007
Cr-Commit-Position: refs/heads/master@{#456118}
Committed: https://chromium.googlesource.com/chromium/src/+/5299daa07febf8a3822227397e1b24f0596d7cee

[sky, 2017-03-10 15:45:03]

https://codereview.chromium.org/2738063007/diff/1/ui/app_list/views/folder_he...
File ui/app_list/views/folder_header_view.cc (right):

https://codereview.chromium.org/2738063007/diff/1/ui/app_list/views/folder_he...
ui/app_list/views/folder_header_view.cc:98: folder_name_view_->RequestFocus();
There's no need to check if the view has focus. Focus code checks it already.

[sky, 2017-03-10 15:45:06]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 15:45:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 16:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:33:33]

Dry run: This issue passed the CQ dry run.

[msw, 2017-03-10 17:47:08]

lgtm with a nit

https://codereview.chromium.org/2738063007/diff/1/ui/app_list/views/folder_he...
File ui/app_list/views/folder_header_view.cc (right):

https://codereview.chromium.org/2738063007/diff/1/ui/app_list/views/folder_he...
ui/app_list/views/folder_header_view.cc:98: folder_name_view_->RequestFocus();
On 2017/03/10 15:45:03, sky wrote:
> There's no need to check if the view has focus. Focus code checks it already.

Acknowledged.

https://codereview.chromium.org/2738063007/diff/1/ui/views/controls/webview/w...
File ui/views/controls/webview/webview.cc (right):

https://codereview.chromium.org/2738063007/diff/1/ui/views/controls/webview/w...
ui/views/controls/webview/webview.cc:334: // we need to pass on focus to if
focused.
nit: clarify 'pass on focus to if focused'?

[sky, 2017-03-10 18:05:57]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-10 18:05:57]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2738063007/#ps20001
(title: "comment")

[sky, 2017-03-10 18:06:12]

https://codereview.chromium.org/2738063007/diff/1/ui/views/controls/webview/w...
File ui/views/controls/webview/webview.cc (right):

https://codereview.chromium.org/2738063007/diff/1/ui/views/controls/webview/w...
ui/views/controls/webview/webview.cc:334: // we need to pass on focus to if
focused.
On 2017/03/10 17:47:08, msw wrote:
> nit: clarify 'pass on focus to if focused'?

Done.

[commit-bot: I haz the power, 2017-03-10 18:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:53:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489169157523020,
"parent_rev": "e86cff1a78d3b1f75b454487afee3101d3504519", "commit_rev":
"5299daa07febf8a3822227397e1b24f0596d7cee"}

[commit-bot: I haz the power, 2017-03-10 18:55:09]

Description was changed from

==========
Removes unnecessary calls to FocusManager

In general View::RequestFocus() and FocusManager::SetFocusedView() do
the same thing. The only exception to that is the SetFocusedView()
does not check if the view wants focus, where as View::RequestFocus()
does. For the cases I'm changing here RequestFocus() is fine.

BUG=none
TEST=none
R=msw@chromium.org
==========

to

==========
Removes unnecessary calls to FocusManager

In general View::RequestFocus() and FocusManager::SetFocusedView() do
the same thing. The only exception to that is the SetFocusedView()
does not check if the view wants focus, where as View::RequestFocus()
does. For the cases I'm changing here RequestFocus() is fine.

BUG=none
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2738063007
Cr-Commit-Position: refs/heads/master@{#456118}
Committed:
https://chromium.googlesource.com/chromium/src/+/5299daa07febf8a3822227397e1b...
==========

[commit-bot: I haz the power, 2017-03-10 18:55:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5299daa07febf8a3822227397e1b...