chrome/browser/ui/views/first_run_bubble_unittest.cc - Issue 2738063007: Removes unnecessary calls to FocusManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/first_run_bubble_unittest.cc

Issue 2738063007: Removes unnecessary calls to FocusManager (Closed)

Patch Set: comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/first_run_bubble_unittest.cc

diff --git a/chrome/browser/ui/views/first_run_bubble_unittest.cc b/chrome/browser/ui/views/first_run_bubble_unittest.cc

index 0686615acb84b8741cb4acd414b1234cb9ecd19c..9e33eee9ea755d2fa53256205a430b9aec1e55ec 100644

--- a/chrome/browser/ui/views/first_run_bubble_unittest.cc

+++ b/chrome/browser/ui/views/first_run_bubble_unittest.cc

@@ -103,8 +103,7 @@ void FirstRunBubbleTest::CreateAndCloseBubbleOnEventTest(ui::Event* event) {

FirstRunBubble::ShowBubble(NULL, anchor_widget->GetContentsView());

EXPECT_TRUE(delegate != NULL);

- anchor_widget->GetFocusManager()->SetFocusedView(

- anchor_widget->GetContentsView());

+ anchor_widget->GetContentsView()->RequestFocus();

std::unique_ptr<WidgetClosingObserver> widget_observer(

new WidgetClosingObserver(delegate->GetWidget()));