Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issue 2738053003: Change "add shortcut" back to "add to homescreen" for the "ADD" language variant. (Closed)

Created:
3 years, 9 months ago by dominickn
Modified:
3 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, srahim+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change "add shortcut" back to "add to homescreen" for the "ADD" language variant. Experimental results have shown that using the string "Add" in the app banner leads to an increase in CTR. However, "Add shortcut" in the menu item reduces CTR compared to "Add to homescreen". This CL changes "Add shortcut" back to "Add to homescreen" in the menu item when variations specifies that the language should be "Add" in the app banner. BUG=662286 Review-Url: https://codereview.chromium.org/2738053003 Cr-Commit-Position: refs/heads/master@{#455877} Committed: https://chromium.googlesource.com/chromium/src/+/1055c94a39ee3096f347bd1293a3742e77a0474c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dominickn
PTAL, thanks! The intention here is that when the "add" experiment is on, we should ...
3 years, 9 months ago (2017-03-09 00:19:27 UTC) #4
gone
lgtm
3 years, 9 months ago (2017-03-09 19:17:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738053003/1
3 years, 9 months ago (2017-03-09 22:05:15 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 22:11:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1055c94a39ee3096f347bd1293a3...

Powered by Google App Engine
This is Rietveld 408576698