[css-align] Implement place-items alignment shorthand

[css-align] Implement place-items alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/qCfsZJhGtOQ

BUG=668639
Review-Url: https://codereview.chromium.org/2737843003
Cr-Commit-Position: refs/heads/master@{#462003}
Committed: https://chromium.googlesource.com/chromium/src/+/4028e23294216bb50e416b43ca9e2a30b95d164b

[jfernandez, 2017-03-08 09:27:32]

Description was changed from

==========
[css-align] Implement place-content alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4

BUG=668639
==========

to

==========
[css-align] Implement place-items alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4

BUG=668639
==========

[jfernandez, 2017-03-08 09:27:32]

jfernandez@igalia.com changed reviewers:
+ meade@chromium.org, rbyers@chromium.org, rego@igalia.com, svillar@igalia.com,
tkent@chromium.org

[jfernandez, 2017-03-08 09:55:23]

Patch sent out for review.

[meade_UTC10, 2017-03-09 05:39:37]

lgtm

https://codereview.chromium.org/2737843003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html
(right):

https://codereview.chromium.org/2737843003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html:6:
place-items: normal;
nit: please use 2-indenting for html, css and js.

https://codereview.chromium.org/2737843003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html:87:
function checkPlaceItemsValues(element, value, alignValue, justifyValue)
nit: Inconsistent use of opening brackets on same or new line - please make them
all on the same line.

https://codereview.chromium.org/2737843003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html:246:
checkPlaceItemsInitialValue();
This function is only used here, why not put the logic in the test directly?

https://codereview.chromium.org/2737843003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html:250:
checkPlaceItemsInheritValue();
ditto

[Rick Byers, 2017-03-27 21:28:40]

rbyers@chromium.org changed reviewers:
- rbyers@chromium.org

[jfernandez, 2017-04-04 12:47:45]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-04-04 12:47:46]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2737843003/#ps20001
(title: "Patch rebasd for landing")

[commit-bot: I haz the power, 2017-04-04 12:47:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 14:21:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 14:21:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jfernandez, 2017-04-04 14:39:03]

jfernandez@igalia.com changed reviewers:
+ rbyers@chromium.org

[jfernandez, 2017-04-04 14:40:20]

I think this patch need API OWNERS approval, so @tkent or @rbyers could you
please take a look ?

[jfernandez, 2017-04-04 14:58:41]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-04-04 14:58:42]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2737843003/#ps40001
(title: "Fixed layout tests.")

[commit-bot: I haz the power, 2017-04-04 14:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 16:21:41]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jfernandez, 2017-04-04 22:42:17]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-04-04 22:42:17]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2737843003/#ps60001
(title: "More layout tests fixes.")

[commit-bot: I haz the power, 2017-04-04 22:43:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:50:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2017-04-05 01:55:58]

lgtm.

> The intent-to-implement-and-ship of CSS Box Alignment shorthands is:
>
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4


The URL looks wrong.

[jfernandez, 2017-04-05 07:26:38]

Description was changed from

==========
[css-align] Implement place-items alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4

BUG=668639
==========

to

==========
[css-align] Implement place-items alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/qCfsZJhGtOQ

BUG=668639
==========

[jfernandez, 2017-04-05 07:27:23]

The CQ bit was checked by jfernandez@igalia.com

[commit-bot: I haz the power, 2017-04-05 07:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:33:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491377243846420,
"parent_rev": "b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3", "commit_rev":
"4028e23294216bb50e416b43ca9e2a30b95d164b"}

[commit-bot: I haz the power, 2017-04-05 07:34:36]

Description was changed from

==========
[css-align] Implement place-items alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/qCfsZJhGtOQ

BUG=668639
==========

to

==========
[css-align] Implement place-items alignment shorthand

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/qCfsZJhGtOQ

BUG=668639

Review-Url: https://codereview.chromium.org/2737843003
Cr-Commit-Position: refs/heads/master@{#462003}
Committed:
https://chromium.googlesource.com/chromium/src/+/4028e23294216bb50e416b43ca9e...
==========

[commit-bot: I haz the power, 2017-04-05 07:34:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4028e23294216bb50e416b43ca9e...