Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

Issue 2737843003: [css-align] Implement place-items alignment shorthand (Closed)
Patch Set: More layout tests fixes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
diff --git a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
index b27f99d5db493854279ed48a7e3f69bed5e88112..3d719f225864e2797a9ec65493e8ab6164daea8e 100644
--- a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
+++ b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
@@ -463,7 +463,9 @@ String StylePropertySerializer::getPropertyValue(
case CSSPropertyGridGap:
return getShorthandValue(gridGapShorthand());
case CSSPropertyPlaceContent:
- return placeContentPropertyValue();
+ return getAlignmentShorthandValue(placeContentShorthand());
+ case CSSPropertyPlaceItems:
+ return getAlignmentShorthandValue(placeItemsShorthand());
case CSSPropertyFont:
return fontValue();
case CSSPropertyFontVariant:
@@ -858,10 +860,11 @@ String StylePropertySerializer::getCommonValue(
return res;
}
-String StylePropertySerializer::placeContentPropertyValue() const {
- String value = getCommonValue(placeContentShorthand());
+String StylePropertySerializer::getAlignmentShorthandValue(
+ const StylePropertyShorthand& shorthand) const {
+ String value = getCommonValue(shorthand);
if (value.isNull() || value.isEmpty())
- return getShorthandValue(placeContentShorthand());
+ return getShorthandValue(shorthand);
return value;
}

Powered by Google App Engine
This is Rietveld 408576698