Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id:40001 of https://codereview.chromium.org/2720513003/ )

Reason for revert:
Sorry, I realize this isn't on a waterfall yet but we're very closed to launching PlzNavigate.

I bisected the failure of NavigatingExtensionPopupBrowserTest.DownloadViaPost on Mac with --enable-browser-side-navigation

Original issue's description:
> Reland: Switch WindowedNotificationObserver to use base::RunLoop.
> 
> Now it will quit the message loop immediately after receiving the
> notification. Also it does not allow nested tasks anymore.
> 
> Relanding after fixing test failures (bugs 695835, 695780).
> 
> Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.
> 
> BUG=668707
> 
> Review-Url: https://codereview.chromium.org/2720513003
> Cr-Commit-Position: refs/heads/master@{#454872}
> Committed: https://chromium.googlesource.com/chromium/src/+/d6ecbaf377cb296924168a77832c80ef53c75667

TBR=jochen@chromium.org,bartfab@chromium.org,rdevlin.cronin@chromium.org,ahest@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668707
Review-Url: https://codereview.chromium.org/2737823002
Cr-Commit-Position: refs/heads/master@{#455207}
Committed: https://chromium.googlesource.com/chromium/src/+/84fa74314b5e4c1da24ee66dea4f81ec0fd5a464

[jam, 2017-03-07 19:24:26]

The CQ bit was checked by jam@chromium.org

[jam, 2017-03-07 19:24:27]

Created Revert of Reland: Switch WindowedNotificationObserver to use
base::RunLoop.

[commit-bot: I haz the power, 2017-03-07 19:25:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Semashko, 2017-03-07 19:36:21]

On 2017/03/07 19:24:27, jam wrote:
> Created Revert of Reland: Switch WindowedNotificationObserver to use
> base::RunLoop.

Hi!

Maybe you can defer the revert for an hour or two? I'll try to fix the test
right now, and it is likely that it won't be hard.

[commit-bot: I haz the power, 2017-03-07 20:48:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488914666800250, "parent_rev":
"561441d0db9860bb1b079190f27f5a86be38f221", "commit_rev":
"84fa74314b5e4c1da24ee66dea4f81ec0fd5a464"}

[commit-bot: I haz the power, 2017-03-07 20:49:10]

Description was changed from

==========
Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop.
(patchset #3 id:40001 of https://codereview.chromium.org/2720513003/ )

Reason for revert:
Sorry, I realize this isn't on a waterfall yet but we're very closed to
launching PlzNavigate.

I bisected the failure of NavigatingExtensionPopupBrowserTest.DownloadViaPost on
Mac with --enable-browser-side-navigation

Original issue's description:
> Reland: Switch WindowedNotificationObserver to use base::RunLoop.
> 
> Now it will quit the message loop immediately after receiving the
> notification. Also it does not allow nested tasks anymore.
> 
> Relanding after fixing test failures (bugs 695835, 695780).
> 
> Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.
> 
> BUG=668707
> 
> Review-Url: https://codereview.chromium.org/2720513003
> Cr-Commit-Position: refs/heads/master@{#454872}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d6ecbaf377cb296924168a77832c...

TBR=jochen@chromium.org,bartfab@chromium.org,rdevlin.cronin@chromium.org,ahes...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668707
==========

to

==========
Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop.
(patchset #3 id:40001 of https://codereview.chromium.org/2720513003/ )

Reason for revert:
Sorry, I realize this isn't on a waterfall yet but we're very closed to
launching PlzNavigate.

I bisected the failure of NavigatingExtensionPopupBrowserTest.DownloadViaPost on
Mac with --enable-browser-side-navigation

Original issue's description:
> Reland: Switch WindowedNotificationObserver to use base::RunLoop.
> 
> Now it will quit the message loop immediately after receiving the
> notification. Also it does not allow nested tasks anymore.
> 
> Relanding after fixing test failures (bugs 695835, 695780).
> 
> Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.
> 
> BUG=668707
> 
> Review-Url: https://codereview.chromium.org/2720513003
> Cr-Commit-Position: refs/heads/master@{#454872}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d6ecbaf377cb296924168a77832c...

TBR=jochen@chromium.org,bartfab@chromium.org,rdevlin.cronin@chromium.org,ahes...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668707

Review-Url: https://codereview.chromium.org/2737823002
Cr-Commit-Position: refs/heads/master@{#455207}
Committed:
https://chromium.googlesource.com/chromium/src/+/84fa74314b5e4c1da24ee66dea4f...
==========

[commit-bot: I haz the power, 2017-03-07 20:49:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84fa74314b5e4c1da24ee66dea4f...

[jam, 2017-03-07 21:02:19]

On 2017/03/07 19:36:21, Alexander Semashko wrote:
> On 2017/03/07 19:24:27, jam wrote:
> > Created Revert of Reland: Switch WindowedNotificationObserver to use
> > base::RunLoop.
> 
> Hi!
> 
> Maybe you can defer the revert for an hour or two? I'll try to fix the test
> right now, and it is likely that it won't be hard.

Sorry just saw this, in the future feel free to unclick the CQ button till I
reply.

[Alexander Semashko, 2017-03-07 21:57:10]

On 2017/03/07 21:02:19, jam wrote:
> On 2017/03/07 19:36:21, Alexander Semashko wrote:
> > On 2017/03/07 19:24:27, jam wrote:
> > > Created Revert of Reland: Switch WindowedNotificationObserver to use
> > > base::RunLoop.
> > 
> > Hi!
> > 
> > Maybe you can defer the revert for an hour or two? I'll try to fix the test
> > right now, and it is likely that it won't be hard.
> 
> Sorry just saw this, in the future feel free to unclick the CQ button till I
> reply.

I don't have rights to do that  - Commit queue not available (can’t edit this
change).

BTW, is NavigatingExtensionPopupBrowserTest.DownloadViaPost the only test that
was failing?

[jam, 2017-03-08 04:56:39]

On 2017/03/07 21:57:10, Alexander Semashko wrote:
> On 2017/03/07 21:02:19, jam wrote:
> > On 2017/03/07 19:36:21, Alexander Semashko wrote:
> > > On 2017/03/07 19:24:27, jam wrote:
> > > > Created Revert of Reland: Switch WindowedNotificationObserver to use
> > > > base::RunLoop.
> > > 
> > > Hi!
> > > 
> > > Maybe you can defer the revert for an hour or two? I'll try to fix the
test
> > > right now, and it is likely that it won't be hard.
> > 
> > Sorry just saw this, in the future feel free to unclick the CQ button till I
> > reply.
> 
> I don't have rights to do that  - Commit queue not available (can’t edit this
> change).
> 
> BTW, is NavigatingExtensionPopupBrowserTest.DownloadViaPost the only test that
> was failing?

That's the only failure with PlzNavigate that I saw.