Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2737673003: Revert of Catch up the spec update in CSS Rhythmic Sizing (Closed)

Created:
3 years, 9 months ago by sclittle
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10, sashab, kojii, eae
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, Timothy Loh, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Catch up the spec update in CSS Rhythmic Sizing (patchset #7 id:120001 of https://codereview.chromium.org/2704343003/ ) Reason for revert: Broke https://build.chromium.org/p/chromium/builders/Linux%20x64 See https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34559 and https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F34559%2F%2B%2Frecipes%2Fsteps%2Fcompile_confirm_no-op%2F0%2Fstdout Original issue's description: > Catch up the spec update in CSS Rhythmic Sizing > > This patch catches up spec changes in CSS Rhythmic Sizing[1]. In > particular: > 1. The property name was changed to 'line-height-step'. > 2. The value syntax was changed to single <length>. > 3. The baseline position feature was removed. > > Tests in csswg-test were updated[2] and imported to fail. All of them > pass in this patch. > > The feature is still behind the flag. > > [1] https://drafts.csswg.org/css-rhythm/ > [2] https://github.com/w3c/csswg-test/commit/50a861a451a1fe9cc80044568c257212729779fa > > BUG=586413 > > Review-Url: https://codereview.chromium.org/2704343003 > Cr-Commit-Position: refs/heads/master@{#455008} > Committed: https://chromium.googlesource.com/chromium/src/+/2344921f94b85be9884ed847d9a041a5e2575946 TBR=meade@chromium.org,sashab@chromium.org,eae@chromium.org,kojii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586413 Review-Url: https://codereview.chromium.org/2737673003 Cr-Commit-Position: refs/heads/master@{#455020} Committed: https://chromium.googlesource.com/chromium/src/+/3204d73f00beb67fb13aaf079be34ae10f7b6749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-dynamic-001-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-parsing-001-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 chunks +12 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeightStep.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPISnapHeight.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 2 chunks +27 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sclittle
Created Revert of Catch up the spec update in CSS Rhythmic Sizing
3 years, 9 months ago (2017-03-07 01:27:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737673003/1
3 years, 9 months ago (2017-03-07 01:27:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3204d73f00beb67fb13aaf079be34ae10f7b6749
3 years, 9 months ago (2017-03-07 01:30:25 UTC) #6
eae
3 years, 9 months ago (2017-03-07 01:36:54 UTC) #7
Message was sent while issue was closed.
LGTM (post facto)

Powered by Google App Engine
This is Rietveld 408576698