Catch up the spec update in CSS Rhythmic Sizing

Catch up the spec update in CSS Rhythmic Sizing

This patch catches up spec changes in CSS Rhythmic Sizing[1]. In
particular:
1. The property name was changed to 'line-height-step'.
2. The value syntax was changed to single <length>.
3. The baseline position feature was removed.

Tests in csswg-test were updated[2] and imported to fail. All of them
pass in this patch.

The feature is still behind the flag.

[1] https://drafts.csswg.org/css-rhythm/
[2] https://github.com/w3c/csswg-test/commit/50a861a451a1fe9cc80044568c257212729779fa

BUG=586413
Review-Url: https://codereview.chromium.org/2704343003
Cr-Commit-Position: refs/heads/master@{#455008}
Committed: https://chromium.googlesource.com/chromium/src/+/2344921f94b85be9884ed847d9a041a5e2575946

[kojii, 2017-03-03 15:32:16]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 15:32:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 17:13:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-03-03 17:35:44]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 17:36:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 19:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:08:58]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-03-05 15:43:34]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-05 15:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-05 16:19:26]

Description was changed from

==========
WIP: line-height-step

BUG=
==========

to

==========
Catch up the spec update in CSS Rhythmic Sizing

This patch catches up spec changes in CSS Rhythmic Sizing[1]. In
particular:
1. The property name was changed to 'line-height-step'.
2. The value syntax was changed to single <length>.
3. The baseline position feature was removed.

Tests in csswg-test were updated[2] and imported to fail. All of them
pass in this patch.

The feature is still behind the flag.

[1] https://drafts.csswg.org/css-rhythm/
[2]
https://github.com/w3c/csswg-test/commit/50a861a451a1fe9cc80044568c2572127297...

BUG=586413
==========

[kojii, 2017-03-05 16:20:37]

kojii@chromium.org changed reviewers:
+ timloh@chromium.org

[kojii, 2017-03-05 16:20:38]

timloh@, PTAL for css/style. I learned the new style system based on json5, I
hope I didn't miss any.

[commit-bot: I haz the power, 2017-03-05 17:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 17:24:55]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2017-03-06 00:40:25]

timloh@chromium.org changed reviewers:
+ meade@chromium.org

[Timothy Loh, 2017-03-06 00:40:26]

Hi Koji,

I'm no longer working on the Style team (I'm working on Permissions now), but
Eddy (meade@) is the current TL of the team and should be able to help with
either reviewing or redirecting to relevant team members.

[Timothy Loh, 2017-03-06 00:40:27]

Hi Koji,

I'm no longer working on the Style team (I'm working on Permissions now), but
Eddy (meade@) is the current TL of the team and should be able to help with
either reviewing or redirecting to relevant team members.

[kojii, 2017-03-06 01:04:00]

Oh, I wasn't aware of that. Congratulations, I hope you enjoy the new team!!

meade@, PTAL.

[meade_UTC10, 2017-03-06 02:40:19]

meade@chromium.org changed reviewers:
+ sashab@chromium.org
- timloh@chromium.org

[meade_UTC10, 2017-03-06 02:40:20]

This lgtm, simpler code ftw!

Sasha, would you mind double checking to make sure I didn't miss anything?
Thanks!

https://codereview.chromium.org/2704343003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSProperties.json5 (right):

https://codereview.chromium.org/2704343003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSProperties.json5:1620: name:
"line-height-step",
This should be in alphabetical order. Would you mind moving this up with the
rest of the l's?

[sashab, 2017-03-06 02:57:58]

LGTM and +bugsnash who should be doing ribbon reviews from now on :D

[kojii, 2017-03-06 03:04:35]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 03:04:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-06 03:05:54]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-03-06 03:05:56]

eae@, PTAL for layout/frame.

https://codereview.chromium.org/2704343003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSProperties.json5 (right):

https://codereview.chromium.org/2704343003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSProperties.json5:1620: name:
"line-height-step",
On 2017/03/06 at 02:40:20, Eddy wrote:
> This should be in alphabetical order. Would you mind moving this up with the
rest of the l's?

Done.

[commit-bot: I haz the power, 2017-03-06 04:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 04:44:33]

Dry run: This issue passed the CQ dry run.

[eae, 2017-03-07 00:10:05]

RS LGTM

[kojii, 2017-03-07 00:48:17]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-03-07 00:48:17]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2704343003/#ps120001
(title: "Sorted CSSProperties.json5 alphabetically (meade@'s nit)")

[commit-bot: I haz the power, 2017-03-07 00:49:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 00:55:24]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488847697526500,
"parent_rev": "7e8bbb8e437db0b5cb65a6a84f1f3b0b67ca3a3e", "commit_rev":
"2344921f94b85be9884ed847d9a041a5e2575946"}

[commit-bot: I haz the power, 2017-03-07 00:56:07]

Description was changed from

==========
Catch up the spec update in CSS Rhythmic Sizing

This patch catches up spec changes in CSS Rhythmic Sizing[1]. In
particular:
1. The property name was changed to 'line-height-step'.
2. The value syntax was changed to single <length>.
3. The baseline position feature was removed.

Tests in csswg-test were updated[2] and imported to fail. All of them
pass in this patch.

The feature is still behind the flag.

[1] https://drafts.csswg.org/css-rhythm/
[2]
https://github.com/w3c/csswg-test/commit/50a861a451a1fe9cc80044568c2572127297...

BUG=586413
==========

to

==========
Catch up the spec update in CSS Rhythmic Sizing

This patch catches up spec changes in CSS Rhythmic Sizing[1]. In
particular:
1. The property name was changed to 'line-height-step'.
2. The value syntax was changed to single <length>.
3. The baseline position feature was removed.

Tests in csswg-test were updated[2] and imported to fail. All of them
pass in this patch.

The feature is still behind the flag.

[1] https://drafts.csswg.org/css-rhythm/
[2]
https://github.com/w3c/csswg-test/commit/50a861a451a1fe9cc80044568c2572127297...

BUG=586413

Review-Url: https://codereview.chromium.org/2704343003
Cr-Commit-Position: refs/heads/master@{#455008}
Committed:
https://chromium.googlesource.com/chromium/src/+/2344921f94b85be9884ed847d9a0...
==========

[commit-bot: I haz the power, 2017-03-07 00:56:09]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/2344921f94b85be9884ed847d9a0...

[sclittle, 2017-03-07 01:27:05]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2737673003/ by sclittle@chromium.org.

The reason for reverting is: Broke
https://build.chromium.org/p/chromium/builders/Linux%20x64

See https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34559 and
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F3....

[kojii, 2017-03-07 18:08:53]

Thank you Scott!