Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2737653006: Add a new mechanism for watching SVGElement 'href' targets (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new mechanism for watching SVGElement 'href' targets This CL adds a new mechanism for watching elements referenced via 'href' attributes. It uses IdTargetObserver as the basis adding a callback for notification. This is a step away from relying on SVGTreeScopeResources for tracking of "pending" elements for these use cases. Each element is instead does its own tracking via the relevant TreeScope. This will eventually mean that the buildPendingResourcesIfNeeded mechanism can be removed. SVGTextPathElement and SVGMPathElement are updated to use this new scheme. Other uses will be replaced in future CLs. BUG=661598 Review-Url: https://codereview.chromium.org/2737653006 Cr-Commit-Position: refs/heads/master@{#455584} Committed: https://chromium.googlesource.com/chromium/src/+/43f91d7f998095673e151be50bf17fe1b011f080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -33 lines) Patch
M third_party/WebKit/Source/core/svg/SVGMPathElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMPathElement.cpp View 3 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPathElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp View 3 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.h View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.cpp View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-08 18:59:42 UTC) #6
pdr.
Looking great, I like the ultimate direction. LGTM
3 years, 9 months ago (2017-03-08 19:04:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737653006/1
3 years, 9 months ago (2017-03-08 22:57:09 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 23:15:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43f91d7f998095673e151be50bf1...

Powered by Google App Engine
This is Rietveld 408576698