Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGURIReference.cpp

Issue 2737653006: Add a new mechanism for watching SVGElement 'href' targets (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGURIReference.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #include "core/svg/SVGURIReference.h" 21 #include "core/svg/SVGURIReference.h"
22 22
23 #include "core/XLinkNames.h" 23 #include "core/XLinkNames.h"
24 #include "core/dom/IdTargetObserver.h"
24 #include "core/html/parser/HTMLParserIdioms.h" 25 #include "core/html/parser/HTMLParserIdioms.h"
25 #include "core/svg/SVGElement.h" 26 #include "core/svg/SVGElement.h"
26 #include "platform/weborigin/KURL.h" 27 #include "platform/weborigin/KURL.h"
27 28
28 namespace blink { 29 namespace blink {
29 30
31 namespace {
32
33 class SVGElementReferenceObserver : public IdTargetObserver {
34 public:
35 SVGElementReferenceObserver(TreeScope& treeScope,
36 const AtomicString& id,
37 std::unique_ptr<WTF::Closure> closure)
38 : IdTargetObserver(treeScope.idTargetObserverRegistry(), id),
39 m_closure(std::move(closure)) {}
40
41 private:
42 void idTargetChanged() override { (*m_closure)(); }
43 std::unique_ptr<WTF::Closure> m_closure;
44 };
45 }
46
30 SVGURIReference::SVGURIReference(SVGElement* element) 47 SVGURIReference::SVGURIReference(SVGElement* element)
31 : m_href(SVGAnimatedHref::create(element)) { 48 : m_href(SVGAnimatedHref::create(element)) {
32 ASSERT(element); 49 ASSERT(element);
33 m_href->addToPropertyMap(element); 50 m_href->addToPropertyMap(element);
34 } 51 }
35 52
36 DEFINE_TRACE(SVGURIReference) { 53 DEFINE_TRACE(SVGURIReference) {
37 visitor->trace(m_href); 54 visitor->trace(m_href);
38 } 55 }
39 56
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 const TreeScope& treeScope, 108 const TreeScope& treeScope,
92 AtomicString* fragmentIdentifier) { 109 AtomicString* fragmentIdentifier) {
93 AtomicString id = fragmentIdentifierFromIRIString(urlString, treeScope); 110 AtomicString id = fragmentIdentifierFromIRIString(urlString, treeScope);
94 if (id.isEmpty()) 111 if (id.isEmpty())
95 return nullptr; 112 return nullptr;
96 if (fragmentIdentifier) 113 if (fragmentIdentifier)
97 *fragmentIdentifier = id; 114 *fragmentIdentifier = id;
98 return treeScope.getElementById(id); 115 return treeScope.getElementById(id);
99 } 116 }
100 117
118 Element* SVGURIReference::observeTarget(Member<IdTargetObserver>& observer,
119 SVGElement& contextElement) {
120 DCHECK(!observer);
121 TreeScope& treeScope = contextElement.treeScope();
122 AtomicString id = fragmentIdentifierFromIRIString(hrefString(), treeScope);
123 if (id.isEmpty())
124 return nullptr;
125 observer = new SVGElementReferenceObserver(
126 treeScope, id,
127 WTF::bind(&SVGElement::buildPendingResource,
128 wrapWeakPersistent(&contextElement)));
129 return treeScope.getElementById(id);
130 }
131
132 void SVGURIReference::unobserveTarget(Member<IdTargetObserver>& observer) {
133 if (!observer)
134 return;
135 observer->unregister();
136 observer = nullptr;
137 }
138
101 } // namespace blink 139 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGURIReference.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698