Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2737623006: Revert of [instrumentation] Introduce InspectorTraceEvents agent (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
dgozman, alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [instrumentation] Introduce InspectorTraceEvents agent (patchset #3 id:40001 of https://codereview.chromium.org/2729613008/ ) Reason for revert: Speculative; looks like this broke component builds for a bunch of people and bots, https://crbug.com/699477 Original issue's description: > [instrumentation] Introduce InspectorTraceEvents agent > > Clean the instrumented code up by moving "devtools.timeline" trace events into the agent. > > BUG=695625 > > Review-Url: https://codereview.chromium.org/2729613008 > Cr-Commit-Position: refs/heads/master@{#455197} > Committed: https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52371bc8b035a5 TBR=pfeldman@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695625 Review-Url: https://codereview.chromium.org/2737623006 Cr-Commit-Position: refs/heads/master@{#455452} Committed: https://chromium.googlesource.com/chromium/src/+/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -149 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 4 chunks +4 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 5 chunks +19 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +23 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 4 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
Created Revert of [instrumentation] Introduce InspectorTraceEvents agent
3 years, 9 months ago (2017-03-08 15:07:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737623006/1
3 years, 9 months ago (2017-03-08 15:07:24 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 15:08:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c1275bf5e9c98c1bcb01cb86be1...

Powered by Google App Engine
This is Rietveld 408576698