[instrumentation] Introduce InspectorTraceEvents agent

[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into the agent.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_clang_dbg;master.tryserver.chromium.win:win_clang_x64_dbg


Review-Url: https://codereview.chromium.org/2729613008
Cr-Original-Commit-Position: refs/heads/master@{#455197}
Committed: https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52371bc8b035a5
Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455554}
Committed: https://chromium.googlesource.com/chromium/src/+/ac0269296fe6f43e9e15b4b56e2a7ab47156e573

[alph, 2017-03-03 23:38:58]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-03-05 06:09:48]

Description was changed from

==========
[instrumentation] Introduce TimlineAgent and route timeline network
instrumentation through it.

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

to

==========
[instrumentation] Introduce TimleineAgent and route timeline network
instrumentation through it.

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

[dgozman, 2017-03-05 06:09:56]

Description was changed from

==========
[instrumentation] Introduce TimleineAgent and route timeline network
instrumentation through it.

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

to

==========
[instrumentation] Introduce TimelineAgent and route timeline network
instrumentation through it.

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

[dgozman, 2017-03-05 06:10:40]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-03-05 06:10:40]

Should we settle between Timeline, Tracing and Performance once and for all?

[alph, 2017-03-06 22:45:41]

ptal

[pfeldman, 2017-03-06 23:31:25]

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
(right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py:433:
return "InspectorTraceEvents"
Just use TraceEvents as a name with no special-case.

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:73:
TRACE_EVENT1("devtools.timeline", "ResourceSendRequest", "data",
why is it scoped?

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h:70: void
init(InstrumentingAgents* instrumentingAgents,
Let's put those into .cpp

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:476:
probe::didReceiveEncodedDataLength(frame(), identifier, encodedDataLength);
You need to follow up and fix this.

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:360:
m_session->append(new InspectorTraceEvents());
Do you want it earlier?

[alph, 2017-03-07 00:57:48]

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
(right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py:433:
return "InspectorTraceEvents"
On 2017/03/06 23:31:24, pfeldman wrote:
> Just use TraceEvents as a name with no special-case.

Done.

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:73:
TRACE_EVENT1("devtools.timeline", "ResourceSendRequest", "data",
On 2017/03/06 23:31:24, pfeldman wrote:
> why is it scoped?

Done.

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h:70: void
init(InstrumentingAgents* instrumentingAgents,
On 2017/03/06 23:31:24, pfeldman wrote:
> Let's put those into .cpp

Done.

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:476:
probe::didReceiveEncodedDataLength(frame(), identifier, encodedDataLength);
On 2017/03/06 23:31:24, pfeldman wrote:
> You need to follow up and fix this.

Acknowledged.

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/2729613008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:360:
m_session->append(new InspectorTraceEvents());
On 2017/03/06 23:31:24, pfeldman wrote:
> Do you want it earlier?

Done.

[pfeldman, 2017-03-07 00:59:39]

lgtm

[alph, 2017-03-07 00:59:53]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:00:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-03-07 01:55:09]

The CQ bit was unchecked by alph@chromium.org

[alph, 2017-03-07 01:56:05]

Description was changed from

==========
[instrumentation] Introduce TimelineAgent and route timeline network
instrumentation through it.

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

to

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

[alph, 2017-03-07 01:56:12]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:57:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:17:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[alph, 2017-03-07 17:16:47]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-07 17:17:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 20:23:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488907007687600,
"parent_rev": "5a09b9fc63346e31b4a0ca4d34a31ff1e84b7ca4", "commit_rev":
"931b43e777872ff7d61803326c52371bc8b035a5"}

[commit-bot: I haz the power, 2017-03-07 20:24:34]

Description was changed from

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
==========

to

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625

Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
==========

[commit-bot: I haz the power, 2017-03-07 20:24:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...

[Nico, 2017-03-08 15:07:00]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2737623006/ by thakis@chromium.org.

The reason for reverting is: Speculative; looks like this broke component builds
for a bunch of people and bots, https://crbug.com/699477.

[alph, 2017-03-08 18:49:25]

Description was changed from

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625

Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
==========

to

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625

Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
==========

[alph, 2017-03-08 19:41:41]

Description was changed from

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625

Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
==========

to

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_clang_dbg;master.tryserver.chromium.win:win_clang_x64_dbg


Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
==========

[alph, 2017-03-08 19:48:23]

Trying to reland the patch after pkasting@ removed "using protocol::Response"
out of header files. Thanks Peter!
Also added affected trybots to CQ.

[alph, 2017-03-08 19:50:50]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:51:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:10:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489002650588420,
"parent_rev": "c2bcb05bec6322e36581d3b2911090147c5e12a3", "commit_rev":
"ac0269296fe6f43e9e15b4b56e2a7ab47156e573"}

[commit-bot: I haz the power, 2017-03-08 22:11:36]

Description was changed from

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_clang_dbg;master.tryserver.chromium.win:win_clang_x64_dbg


Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
==========

to

==========
[instrumentation] Introduce InspectorTraceEvents agent

Clean the instrumented code up by moving "devtools.timeline" trace events into
the agent.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_clang_dbg;master.tryserver.chromium.win:win_clang_x64_dbg


Review-Url: https://codereview.chromium.org/2729613008
Cr-Original-Commit-Position: refs/heads/master@{#455197}
Committed:
https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52...
Review-Url: https://codereview.chromium.org/2729613008
Cr-Commit-Position: refs/heads/master@{#455554}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac0269296fe6f43e9e15b4b56e2a...
==========

[commit-bot: I haz the power, 2017-03-08 22:11:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ac0269296fe6f43e9e15b4b56e2a...