Issue 2737563003: Remove VoiceSearchProvider::CreateVoiceSearchBar().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2737563003: Remove VoiceSearchProvider::CreateVoiceSearchBar(). (Closed)

Created:
3 years, 9 months ago by kkhorimoto

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Remove VoiceSearchProvider::CreateVoiceSearchBar(). This functionality is now covered by BuildVoiceSearchBar(). BUG=679719 Review-Url: https://codereview.chromium.org/2642783008 Cr-Commit-Position: refs/heads/master@{#445825} (cherry picked from commit c2cdf6f411f8c5e8e7232fbf32b4b1eacea48268) Review-Url: https://codereview.chromium.org/2737563003 . Cr-Commit-Position: refs/branch-heads/2987@{#781} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/80fa10e4c879c2e549952b1bbb505c8ee8958356

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -16 lines)			Patch
M	ios/chrome/browser/ui/browser_view_controller.mm	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	ios/public/provider/chrome/browser/voice/voice_search_provider.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ios/public/provider/chrome/browser/voice/voice_search_provider.mm	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

kkhorimoto

3 years, 9 months ago (2017-03-07 05:37:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
80fa10e4c879c2e549952b1bbb505c8ee8958356.