Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2737503002: Allow zero-height fragmentainers. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow zero-height fragmentainers. We used to assert against this, but we really can't, since there are legitimiate reasons for a fragmentainer (and fragmentainer groups and column sets) to have zero height, e.g. when its content is zero-height. BUG=698359 Review-Url: https://codereview.chromium.org/2737503002 Cr-Commit-Position: refs/heads/master@{#455040} Committed: https://chromium.googlesource.com/chromium/src/+/2fa8cb1b82fe741f526a5009f17b03158349e681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/zero-height-inner-multicol-at-boundary-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
Some of these assertions have served us well in finding bugs, but I've finally come ...
3 years, 9 months ago (2017-03-06 15:00:03 UTC) #6
eae
LGTM
3 years, 9 months ago (2017-03-07 00:08:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737503002/1
3 years, 9 months ago (2017-03-07 05:44:37 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 05:50:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fa8cb1b82fe741f526a5009f17b...

Powered by Google App Engine
This is Rietveld 408576698