third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp - Issue 2737503002: Allow zero-height fragmentainers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 2737503002: Allow zero-height fragmentainers. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

index 9140ea6aad00768cfb2b2e556c6f119ca27bb636..e747f429b52b2dfdcda8970d6557a6ce4fc75676 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

@@ -326,7 +326,6 @@ LayoutUnit MultiColumnFragmentainerGroup::calculateMaxColumnHeight() const {

LayoutUnit remainingOuterLogicalHeight =

enclosingFragmentationContext->remainingLogicalHeightAt(

blockOffsetInEnclosingFragmentationContext());

- ASSERT(remainingOuterLogicalHeight > 0);

if (maxHeight > remainingOuterLogicalHeight)

maxHeight = remainingOuterLogicalHeight;

}

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp ('k') | no next file » | no next file with comments »