Issue 2737373004: Check that a transaction is opened before closing it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2737373004: Check that a transaction is opened before closing it (Closed)

Created:
3 years, 9 months ago by Miguel Garcia

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Check that a transaction is opened before closing it The introduction of "Close All" provided a situation where we can close a transaction that has not been opened which crashes the XPC service BUG=698911 Review-Url: https://codereview.chromium.org/2735093004 Cr-Commit-Position: refs/heads/master@{#455273} (cherry picked from commit a69a95ffd08ee6447a804526e1bf8c228f7a6952) Review-Url: https://codereview.chromium.org/2737373004 . Cr-Commit-Position: refs/branch-heads/3029@{#82} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8552222d2d23eb37b11a8af041f493185f549990

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/cocoa/notifications/xpc_transaction_handler.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Miguel Garcia

3 years, 9 months ago (2017-03-09 15:14:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8552222d2d23eb37b11a8af041f493185f549990.