Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2735093004: Check that a transaction is opened before closing it (Closed)

Created:
3 years, 9 months ago by Miguel Garcia
Modified:
3 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that a transaction is opened before closing it The introduction of "Close All" provided a situation where we can close a transaction that has not been opened which crashes the XPC service BUG=698911 Review-Url: https://codereview.chromium.org/2735093004 Cr-Commit-Position: refs/heads/master@{#455273} Committed: https://chromium.googlesource.com/chromium/src/+/a69a95ffd08ee6447a804526e1bf8c228f7a6952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/notifications/xpc_transaction_handler.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Miguel Garcia
3 years, 9 months ago (2017-03-07 16:55:22 UTC) #2
Robert Sesek
LGTM
3 years, 9 months ago (2017-03-07 18:51:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735093004/1
3 years, 9 months ago (2017-03-07 22:24:20 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:06:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a69a95ffd08ee6447a804526e1bf...

Powered by Google App Engine
This is Rietveld 408576698