Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2737373003: Move CopyValuesTo to SeededNumberDictionary. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move CopyValuesTo to SeededNumberDictionary. R=ishell@chromium.org BUG=v8:6073 Review-Url: https://codereview.chromium.org/2737373003 Cr-Commit-Position: refs/heads/master@{#43703} Committed: https://chromium.googlesource.com/v8/v8/+/1f2a31c8634ff61937798d8fb997d842274b161c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M src/objects.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.cc View 2 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-09 14:15:58 UTC) #1
Igor Sheludko
lgtm
3 years, 9 months ago (2017-03-09 14:35:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737373003/1
3 years, 9 months ago (2017-03-09 15:11:59 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 15:42:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1f2a31c8634ff61937798d8fb997d842274...

Powered by Google App Engine
This is Rietveld 408576698