Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: src/objects.h

Issue 2737373003: Move CopyValuesTo to SeededNumberDictionary. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 102dc0d698fe0949ee2115c91fcae76407351d2a..0bbb3955da2ef032fb0bae54c7546e01fb41a45f 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -3607,10 +3607,6 @@ class Dictionary: public HashTable<Derived, Shape, Key> {
return DerivedHashTable::Shrink(dictionary, key);
}
- // Sorting support
- // TODO(dcarney): templatize or move to SeededNumberDictionary
- void CopyValuesTo(FixedArray* elements);
-
// Returns the number of elements in the dictionary filtering out properties
// with the specified attributes.
int NumberOfElementsFilterAttributes(PropertyFilter filter);
@@ -3877,6 +3873,9 @@ class SeededNumberDictionary
// non-configurable, non-enumerable, or have getters/setters.
bool HasComplexElements();
+ // Sorting support
+ void CopyValuesTo(FixedArray* elements);
+
// If slow elements are required we will never go back to fast-case
// for the elements kept in this dictionary. We require slow
// elements if an element has been added at an index larger than
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698