Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

WebPagePopupImpl now eagerly initializes m_layerTreeView, which matches what
WebViewImpl does for non-popup content.

BUG=699412, 698464
Review-Url: https://codereview.chromium.org/2737193002
Cr-Commit-Position: refs/heads/master@{#455642}
Committed: https://chromium.googlesource.com/chromium/src/+/a2d48d4e791055524b1dd7870ed2674c98cc6bfc

[skobes, 2017-03-08 21:49:13]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 21:49:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2017-03-08 21:51:33]

Description was changed from

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by r455325.  WebPagePopupImpl
now doesn't set m_isAcceleratedCompositingActive until the end of the first
compositing update, which scheduleAnimation refused to schedule until this bit
was set.

BUG=699412,698464
==========

to

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by r455325.  WebPagePopupImpl
sets m_isAcceleratedCompositingActive during the first compositing update, which
scheduleAnimation refused to schedule until this bit was set.

BUG=699412,698464
==========

[skobes, 2017-03-08 21:53:46]

Description was changed from

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by r455325.  WebPagePopupImpl
sets m_isAcceleratedCompositingActive during the first compositing update, which
scheduleAnimation refused to schedule until this bit was set.

BUG=699412,698464
==========

to

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

BUG=699412,698464
==========

[skobes, 2017-03-08 22:00:51]

Description was changed from

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

BUG=699412,698464
==========

to

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

WebPagePopupImpl now eagerly initializes m_layerTreeView, which matches what
WebViewImpl does for non-popup content.

BUG=699412,698464
==========

[skobes, 2017-03-08 22:33:11]

skobes@chromium.org changed reviewers:
+ bokan@chromium.org

[dpapad, 2017-03-08 22:41:57]

On 2017/03/08 at 22:33:12, skobes wrote:
> 

Thanks for putting up a fix so quickly. BTW, is there an automated test that
could have caught this regression? I am concerned that no Blink test caught this
(but I am also not familiar with the way Blink test's visual fidelity).

[skobes, 2017-03-08 22:44:21]

On 2017/03/08 22:41:57, dpapad wrote:
> Thanks for putting up a fix so quickly. BTW, is there an automated test that
> could have caught this regression? I am concerned that no Blink test caught
this
> (but I am also not familiar with the way Blink test's visual fidelity).

We have layout tests under fast/forms/select-popup but I'm not sure why they
didn't catch this.  I'll look into that separately.

[commit-bot: I haz the power, 2017-03-09 00:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 00:05:50]

Dry run: This issue passed the CQ dry run.

[skobes, 2017-03-09 01:43:12]

skobes@chromium.org changed reviewers:
+ tkent@chromium.org
- bokan@chromium.org

[tkent, 2017-03-09 02:02:45]

On 2017/03/08 at 22:44:21, skobes wrote:
> On 2017/03/08 22:41:57, dpapad wrote:
> > Thanks for putting up a fix so quickly. BTW, is there an automated test that
> > could have caught this regression? I am concerned that no Blink test caught
this
> > (but I am also not familiar with the way Blink test's visual fidelity).
> 
> We have layout tests under fast/forms/select-popup but I'm not sure why they
didn't catch this.  I'll look into that separately.

It was difficult for content_shell to do pixel dump of multiple window contents
as one png file. So content/shell/test_runner/ paints popup content on the main
window manually.

[skobes, 2017-03-09 02:13:01]

On 2017/03/09 02:02:45, tkent wrote:
> It was difficult for content_shell to do pixel dump of multiple window
contents
> as one png file. So content/shell/test_runner/ paints popup content on the
main
> window manually.

Makes sense, thanks.  Would you be ok landing this without a test for now?  I'll
file a bug to add unit tests for WebPagePopupImpl.

[tkent, 2017-03-09 02:14:04]

On 2017/03/09 at 02:13:01, skobes wrote:
> Makes sense, thanks.  Would you be ok landing this without a test for now? 
I'll file a bug to add unit tests for WebPagePopupImpl.

lgtm

[skobes, 2017-03-09 02:14:30]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-03-09 02:15:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:20:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489025670313420, "parent_rev":
"27e9e232d7a4b8c3e255925093f51d8de8fcf63e", "commit_rev":
"a2d48d4e791055524b1dd7870ed2674c98cc6bfc"}

[commit-bot: I haz the power, 2017-03-09 02:20:59]

Description was changed from

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

WebPagePopupImpl now eagerly initializes m_layerTreeView, which matches what
WebViewImpl does for non-popup content.

BUG=699412,698464
==========

to

==========
Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer.

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

WebPagePopupImpl now eagerly initializes m_layerTreeView, which matches what
WebViewImpl does for non-popup content.

BUG=699412,698464

Review-Url: https://codereview.chromium.org/2737193002
Cr-Commit-Position: refs/heads/master@{#455642}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2d48d4e791055524b1dd7870ed2...
==========

[commit-bot: I haz the power, 2017-03-09 02:21:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2d48d4e791055524b1dd7870ed2...