Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 2737193002: Let PagePopupChromeClient schedule frames before attachRootGraphicsLayer. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 bool isViewportPointInWindow(int x, int y); 99 bool isViewportPointInWindow(int x, int y);
100 100
101 // PagePopup function 101 // PagePopup function
102 AXObject* rootAXObject() override; 102 AXObject* rootAXObject() override;
103 void setWindowRect(const IntRect&) override; 103 void setWindowRect(const IntRect&) override;
104 104
105 explicit WebPagePopupImpl(WebWidgetClient*); 105 explicit WebPagePopupImpl(WebWidgetClient*);
106 bool initializePage(); 106 bool initializePage();
107 void destroyPage(); 107 void destroyPage();
108 void initializeLayerTreeView();
108 void setRootGraphicsLayer(GraphicsLayer*); 109 void setRootGraphicsLayer(GraphicsLayer*);
109 void setIsAcceleratedCompositingActive(bool enter);
110 110
111 WebRect windowRectInScreen() const; 111 WebRect windowRectInScreen() const;
112 112
113 WebWidgetClient* m_widgetClient; 113 WebWidgetClient* m_widgetClient;
114 WebViewImpl* m_webView; 114 WebViewImpl* m_webView;
115 Persistent<Page> m_page; 115 Persistent<Page> m_page;
116 Persistent<PagePopupChromeClient> m_chromeClient; 116 Persistent<PagePopupChromeClient> m_chromeClient;
117 PagePopupClient* m_popupClient; 117 PagePopupClient* m_popupClient;
118 bool m_closing; 118 bool m_closing;
119 119
(...skipping 11 matching lines...) Expand all
131 WebWidget, 131 WebWidget,
132 widget, 132 widget,
133 widget->isPagePopup(), 133 widget->isPagePopup(),
134 widget.isPagePopup()); 134 widget.isPagePopup());
135 // WebPagePopupImpl is the only implementation of PagePopup, so no 135 // WebPagePopupImpl is the only implementation of PagePopup, so no
136 // further checking required. 136 // further checking required.
137 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true); 137 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true);
138 138
139 } // namespace blink 139 } // namespace blink
140 #endif // WebPagePopupImpl_h 140 #endif // WebPagePopupImpl_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698