Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2737143002: MIPS64: Fix declaration for bit() function. (Closed)

Created:
3 years, 9 months ago by Ilija.Pavlovic1
Modified:
3 years, 9 months ago
Reviewers:
Clemens Hammacher, ivica.bogosavljevic, ilija.pavlovic, miran.karic, miran.karic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix declaration for bit() function. From declarations of bit() member functions (for structures Register, FPURegister and FPUControlRegister) are removed constexpr specificators. Build V8 will fail if function bit() is declared as a constant expression. TEST= BUG= Review-Url: https://codereview.chromium.org/2737143002 Cr-Commit-Position: refs/heads/master@{#43674} Committed: https://chromium.googlesource.com/v8/v8/+/92da40621303838849e98d26a0cb83e9c04c7a3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/mips64/assembler-mips64.h View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Ilija.Pavlovic1
PTAL
3 years, 9 months ago (2017-03-08 14:37:39 UTC) #2
miran.karic
lgtm
3 years, 9 months ago (2017-03-08 14:43:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737143002/1
3 years, 9 months ago (2017-03-08 14:43:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36201)
3 years, 9 months ago (2017-03-08 14:46:16 UTC) #8
Clemens Hammacher
lgtm LGTM Thanks for this fix. I have to apologize for introducing this. This should ...
3 years, 9 months ago (2017-03-08 15:07:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737143002/1
3 years, 9 months ago (2017-03-08 15:07:40 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 15:09:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/92da40621303838849e98d26a0cb83e9c04...

Powered by Google App Engine
This is Rietveld 408576698