Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2736873006: Fix null pointer dereference in PLSA's scrollbarStyleSource. (Closed)

Created:
3 years, 9 months ago by skobes
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix null pointer dereference in PLSA's scrollbarStyleSource. The scroller inside the alt-text shadow tree created by HTMLImageFallbackHelper was trying to read scrollbar styles from the <img> element, which had no LayoutObject because it was styled with "display: contents". BUG=697247 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2734993002 Cr-Commit-Position: refs/heads/master@{#455148} (cherry picked from commit d23ef9b37d71d31b82613f8ddb8da614cd54c665) Review-Url: https://codereview.chromium.org/2736873006 . Cr-Commit-Position: refs/branch-heads/3029@{#71} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/bff179ffca3cc9e47629a280d8ffd40970bb2b38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/img-display-contents-crash.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/img-display-contents-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
skobes
3 years, 9 months ago (2017-03-08 22:28:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bff179ffca3cc9e47629a280d8ffd40970bb2b38 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698