Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2734993002: Fix null pointer dereference in PLSA's scrollbarStyleSource. (Closed)

Created:
3 years, 9 months ago by skobes
Modified:
3 years, 9 months ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null pointer dereference in PLSA's scrollbarStyleSource. The scroller inside the alt-text shadow tree created by HTMLImageFallbackHelper was trying to read scrollbar styles from the <img> element, which had no LayoutObject because it was styled with "display: contents". BUG=697247 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2734993002 Cr-Commit-Position: refs/heads/master@{#455148} Committed: https://chromium.googlesource.com/chromium/src/+/d23ef9b37d71d31b82613f8ddb8da614cd54c665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/img-display-contents-crash.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/img-display-contents-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
skobes
3 years, 9 months ago (2017-03-07 00:44:02 UTC) #7
szager1
lgtm
3 years, 9 months ago (2017-03-07 00:55:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734993002/1
3 years, 9 months ago (2017-03-07 16:06:39 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 18:32:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d23ef9b37d71d31b82613f8ddb8d...

Powered by Google App Engine
This is Rietveld 408576698