Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2736693003: GpuMain: Fix thread_runner() access DCHECK fail (Closed)

Created:
3 years, 9 months ago by Fady Samuel
Modified:
3 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GpuMain: Fix thread_runner() access DCHECK fail Accessing base::Thread::task_runner() on an arbitrary thread is unsafe. This causes a DCHECK to fail on some mus_ws_unittests. This CL saves the task runner for the gpu thread and the compositor thread in member variables to ensure safe access to the task runners. BUG=none Review-Url: https://codereview.chromium.org/2736693003 Cr-Commit-Position: refs/heads/master@{#454891} Committed: https://chromium.googlesource.com/chromium/src/+/cd2a7b5cf2df1b844fd3894d2d0d5410406fe3ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M services/ui/gpu/gpu_main.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 7 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Fady Samuel
3 years, 9 months ago (2017-03-06 16:59:06 UTC) #3
sadrul
lgtm
3 years, 9 months ago (2017-03-06 18:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736693003/1
3 years, 9 months ago (2017-03-06 18:12:11 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:24:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd2a7b5cf2df1b844fd3894d2d0d...

Powered by Google App Engine
This is Rietveld 408576698