Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2736603004: [DevTools] Pass events to remote frames in inspect mode. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Pass events to remote frames in inspect mode. Before, we inspected a frame owner element for remote frame on click. Now we clear highlight and do not consume event so that remote frame could handle it and inspect proper node inside. BUG=652783 Review-Url: https://codereview.chromium.org/2736603004 Cr-Commit-Position: refs/heads/master@{#455147} Committed: https://chromium.googlesource.com/chromium/src/+/d20a42b6f8b1f703717dac5c7936223ba129e1a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-06 22:02:05 UTC) #2
caseq
lgtm
3 years, 9 months ago (2017-03-06 22:36:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736603004/1
3 years, 9 months ago (2017-03-07 01:03:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395364)
3 years, 9 months ago (2017-03-07 04:25:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736603004/1
3 years, 9 months ago (2017-03-07 06:09:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395719)
3 years, 9 months ago (2017-03-07 09:36:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736603004/1
3 years, 9 months ago (2017-03-07 16:02:45 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 18:30:40 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d20a42b6f8b1f703717dac5c7936...

Powered by Google App Engine
This is Rietveld 408576698