|
|
Chromium Code Reviews
Description[DevTools] Pass events to remote frames in inspect mode.
Before, we inspected a frame owner element for remote frame on click.
Now we clear highlight and do not consume event so that remote frame
could handle it and inspect proper node inside.
BUG=652783
Review-Url: https://codereview.chromium.org/2736603004
Cr-Commit-Position: refs/heads/master@{#455147}
Committed: https://chromium.googlesource.com/chromium/src/+/d20a42b6f8b1f703717dac5c7936223ba129e1a3
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
dgozman@chromium.org changed reviewers: + caseq@chromium.org
Could you please take a look?
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by dgozman@chromium.org
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488902514771480, "parent_rev":
"f47de6fa1c432e87dc270ff96b1089e5983c2cf1", "commit_rev":
"d20a42b6f8b1f703717dac5c7936223ba129e1a3"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Pass events to remote frames in inspect mode. Before, we inspected a frame owner element for remote frame on click. Now we clear highlight and do not consume event so that remote frame could handle it and inspect proper node inside. BUG=652783 ========== to ========== [DevTools] Pass events to remote frames in inspect mode. Before, we inspected a frame owner element for remote frame on click. Now we clear highlight and do not consume event so that remote frame could handle it and inspect proper node inside. BUG=652783 Review-Url: https://codereview.chromium.org/2736603004 Cr-Commit-Position: refs/heads/master@{#455147} Committed: https://chromium.googlesource.com/chromium/src/+/d20a42b6f8b1f703717dac5c7936... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d20a42b6f8b1f703717dac5c7936... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
