Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2736603004: [DevTools] Pass events to remote frames in inspect mode. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index c265cbed6a4e9d2171a31a987a78406ac9444907..27a732dcdb5f5a14140b2367805ea2b0c042b205 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -42,6 +42,7 @@
#include "core/frame/LocalFrameClient.h"
#include "core/frame/Settings.h"
#include "core/frame/VisualViewport.h"
+#include "core/html/HTMLFrameOwnerElement.h"
#include "core/input/EventHandler.h"
#include "core/inspector/InspectorOverlayHost.h"
#include "core/layout/api/LayoutViewItem.h"
@@ -735,6 +736,17 @@ bool InspectorOverlay::handleMouseMove(const WebMouseEvent& event) {
if (!node)
return true;
+ if (node->isFrameOwnerElement()) {
+ HTMLFrameOwnerElement* frameOwner = toHTMLFrameOwnerElement(node);
+ if (frameOwner->contentFrame() &&
+ !frameOwner->contentFrame()->isLocalFrame()) {
+ // Do not consume event so that remote frame can handle it.
+ hideHighlight();
+ m_hoveredNodeForInspectMode.clear();
+ return false;
+ }
+ }
+
Node* eventTarget = (event.modifiers() & WebInputEvent::ShiftKey)
? hoveredNodeForEvent(frame, event, false)
: nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698