Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2736393002: DevTools: split network project into buckets (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: split network project into buckets Currently, for a given target and frame, NetworkProject puts all UISourceCodes in a single project. This is true for UISourceCodes being created for scripts, styles, resources and source maps. In future, however, we'd like to have all the UISourceCodes in a separate projects, which are fully managed by responsible bindings. (design doc: https://goo.gl/rt9RAS). This patch prepares for the step, splitting NetworkProject into multiple "buckets": - ResourcesBucket: contains UISourceCodes for resourceTreeModel resources - ScriptsBucket: contains UISourceCodes for scripts - StyleSheetsBucket: contains UISourceCodes for style sheets - SourceMapBucket: contains UISourceCodes for source map sources Today, the buckets are cleaned up altogether in frameDetached/mainFrameNavigated events. Our goal is to clean up buckets independently. BUG=670180 R=dgozman

Patch Set 1 #

Patch Set 2 : fix tests #

Messages

Total messages: 9 (6 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-09 00:38:58 UTC) #1
dgozman
The code lgtm, but let's do more patches before landing this to be sure it ...
3 years, 9 months ago (2017-03-10 01:51:27 UTC) #8
lushnikov
3 years, 8 months ago (2017-04-04 20:53:50 UTC) #9
I don't think we need this patch any more. It's main point was to prepare for
dependency removal between debugger/css/sourcemap UISourceCodes and
ResourceTreeModel.

The dependency is fully removed in https://codereview.chromium.org/2795193003/#,
so closing this.

Powered by Google App Engine
This is Rietveld 408576698