Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2739983002: DevTools: cleanup script UISourceCodes on executionContextDestroyed (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: cleanup script UISourceCodes on executionContextDestroyed Currently, NetworkProject does a best effort to clean up UISourceCodes when the frame gets detached. Dynamic scripts, for example, are not getting removed. This patch teaches NetworkProject to listen to ExecutionContextDestroyed event in order to remove associated script-related UISourceCodes. As a result, this patch un-binds script-related UISourceCode management from ResourceTreeModel. R=dgozman BUG=670180

Patch Set 1 #

Patch Set 2 : ad jsdoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/dynamic-bindings-frame-attach-detach-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 6 chunks +42 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-09 04:22:40 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-10 01:50:36 UTC) #6
lushnikov
3 years, 8 months ago (2017-04-04 20:50:55 UTC) #7
The "buckets" change which this relies on doesn't seem to be needed - this patch
is re-implemented in https://codereview.chromium.org/2795193003/.

Powered by Google App Engine
This is Rietveld 408576698