Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

Issue 2736373003: Fix wrong paint invalidation container for column spanners (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
index 7b13835870d20bda9a7ea0a6d442b07b4ab1c584..46a7df27619a092463e9318a674c4fc84ffffd59 100644
--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
@@ -133,7 +133,10 @@ PaintInvalidationState::PaintInvalidationState(
// paintInvalidationContainer.
m_paintInvalidationContainerForStackedContents =
m_paintInvalidationContainer;
- } else if (currentObject.isFloatingWithNonContainingBlockParent()) {
+ } else if (currentObject.isFloatingWithNonContainingBlockParent() ||
+ currentObject.isColumnSpanAll()) {
+ // In these cases, the object may belong to an ancestor of the current
+ // paint invalidation container, in paint order.
m_paintInvalidationContainer =
&currentObject.containerForPaintInvalidation();
m_cachedOffsetsEnabled = false;

Powered by Google App Engine
This is Rietveld 408576698