Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2733413002: Recover correctly from positional argument after named argument. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Recover correctly from positional argument after named argument. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/d1a2839a501b8b112fe0f98c924291b634ae535d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename firstNamedArgumentIndex. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 1 chunk +13 lines, -9 lines 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 2732293004 Patch 40001

Messages

Total messages: 6 (2 generated)
ahe
3 years, 9 months ago (2017-03-08 15:15:29 UTC) #2
karlklose
LGTM https://codereview.chromium.org/2733413002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2733413002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode468 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:468: int firstNamedArgument = arguments.length; How about 'firstNamedArgumentIndex'?
3 years, 9 months ago (2017-03-09 09:48:15 UTC) #3
ahe
Thank you, Karl! https://codereview.chromium.org/2733413002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2733413002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode468 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:468: int firstNamedArgument = arguments.length; On 2017/03/09 ...
3 years, 9 months ago (2017-03-09 12:29:33 UTC) #4
ahe
3 years, 9 months ago (2017-03-09 12:34:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d1a2839a501b8b112fe0f98c924291b634ae535d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698